Skip to content

gh-workflow: add page #5767

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Parent: readline: add page
merged 7 commits into from
Apr 16, 2021
Merged

gh-workflow: add page #5767

merged 7 commits into from
Apr 16, 2021

Conversation

@navarroaxel
Copy link
Collaborator

  • The page (if new), does not already exist in the repo.
  • The page is in the correct platform directory (common/, linux/, etc.)
  • The page has 8 or fewer examples.
  • The PR title conforms to the recommended templates.
  • The page follows the content guidelines.
  • The page description includes a link to documentation or a homepage (if applicable).

@navarroaxel navarroaxel added the new command Issues requesting creation of a new page or PRs adding a new page for a command. label Apr 15, 2021
bl-ue
bl-ue reviewed Apr 15, 2021
View reviewed changes
@navarroaxel navarroaxel requested a review from bl-ue April 15, 2021 16:39
bl-ue
bl-ue reviewed Apr 15, 2021
View reviewed changes
@navarroaxel navarroaxel requested a review from bl-ue April 15, 2021 17:15
sbrl
sbrl requested changes Apr 16, 2021
View reviewed changes
Copy link
Member

@sbrl sbrl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the new page! I've left some comments below for you to review.

marchersimon
marchersimon reviewed Apr 16, 2021
View reviewed changes
bl-ue
bl-ue suggested changes Apr 16, 2021
View reviewed changes
navarroaxel and others added 2 commits April 16, 2021 10:05
@navarroaxel navarroaxel requested review from bl-ue and sbrl April 16, 2021 14:38
sbrl
sbrl approved these changes Apr 16, 2021
View reviewed changes
Copy link
Member

@sbrl sbrl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok to me. Thanks, @navarroaxel!

@bl-ue bl-ue merged commit c6b59a0 into master Apr 16, 2021
@bl-ue bl-ue deleted the pages/gh-workflow branch April 16, 2021 14:42
@bl-ue bl-ue mentioned this pull request Apr 20, 2021
Closed
@dmmqz dmmqz mentioned this pull request Sep 18, 2025
Closed
35 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sbrl sbrl sbrl approved these changes

+2 more reviewers

@marchersimon marchersimon marchersimon left review comments

@bl-ue bl-ue bl-ue approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

new command Issues requesting creation of a new page or PRs adding a new page for a command.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@navarroaxel @sbrl @marchersimon @bl-ue